Open
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064221
Total [baseline] (8.899 s) : 0, 8899111
Agent [candidate] (1.069 s) : 0, 1069348
Total [candidate] (8.907 s) : 0, 8907150
section iast
Agent [baseline] (1.236 s) : 0, 1236046
Total [baseline] (9.63 s) : 0, 9630236
Agent [candidate] (1.234 s) : 0, 1233635
Total [candidate] (9.617 s) : 0, 9616734
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (633.148 ms) : 0, 633148
BytebuddyAgent [candidate] (638.385 ms) : 0, 638385
AgentMeter [baseline] (29.476 ms) : 0, 29476
AgentMeter [candidate] (29.713 ms) : 0, 29713
GlobalTracer [baseline] (258.447 ms) : 0, 258447
GlobalTracer [candidate] (259.0 ms) : 0, 259000
AppSec [baseline] (31.894 ms) : 0, 31894
AppSec [candidate] (31.905 ms) : 0, 31905
Debugger [baseline] (59.933 ms) : 0, 59933
Debugger [candidate] (60.302 ms) : 0, 60302
Remote Config [baseline] (601.755 µs) : 0, 602
Remote Config [candidate] (588.557 µs) : 0, 589
Telemetry [baseline] (8.017 ms) : 0, 8017
Telemetry [candidate] (8.26 ms) : 0, 8260
Flare Poller [baseline] (5.067 ms) : 0, 5067
Flare Poller [candidate] (3.548 ms) : 0, 3548
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (801.766 ms) : 0, 801766
BytebuddyAgent [candidate] (800.295 ms) : 0, 800295
AgentMeter [baseline] (11.453 ms) : 0, 11453
AgentMeter [candidate] (11.42 ms) : 0, 11420
GlobalTracer [baseline] (249.117 ms) : 0, 249117
GlobalTracer [candidate] (249.09 ms) : 0, 249090
AppSec [baseline] (26.827 ms) : 0, 26827
AppSec [candidate] (26.765 ms) : 0, 26765
Debugger [baseline] (67.94 ms) : 0, 67940
Debugger [candidate] (64.673 ms) : 0, 64673
Remote Config [baseline] (538.345 µs) : 0, 538
Remote Config [candidate] (515.197 µs) : 0, 515
Telemetry [baseline] (11.249 ms) : 0, 11249
Telemetry [candidate] (13.313 ms) : 0, 13313
Flare Poller [baseline] (4.051 ms) : 0, 4051
Flare Poller [candidate] (4.463 ms) : 0, 4463
IAST [baseline] (25.468 ms) : 0, 25468
IAST [candidate] (25.455 ms) : 0, 25455
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065351
Total [baseline] (11.082 s) : 0, 11081738
Agent [candidate] (1.07 s) : 0, 1070443
Total [candidate] (11.14 s) : 0, 11140019
section appsec
Agent [baseline] (1.254 s) : 0, 1254355
Total [baseline] (11.248 s) : 0, 11248126
Agent [candidate] (1.256 s) : 0, 1256160
Total [candidate] (11.248 s) : 0, 11247814
section iast
Agent [baseline] (1.236 s) : 0, 1236035
Total [baseline] (11.38 s) : 0, 11379638
Agent [candidate] (1.239 s) : 0, 1238629
Total [candidate] (11.401 s) : 0, 11400619
section profiling
Agent [baseline] (1.196 s) : 0, 1195871
Total [baseline] (11.039 s) : 0, 11038619
Agent [candidate] (1.2 s) : 0, 1199937
Total [candidate] (11.077 s) : 0, 11076792
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (632.774 ms) : 0, 632774
BytebuddyAgent [candidate] (637.283 ms) : 0, 637283
AgentMeter [baseline] (29.701 ms) : 0, 29701
AgentMeter [candidate] (29.65 ms) : 0, 29650
GlobalTracer [baseline] (259.734 ms) : 0, 259734
GlobalTracer [candidate] (259.914 ms) : 0, 259914
AppSec [baseline] (31.956 ms) : 0, 31956
AppSec [candidate] (31.942 ms) : 0, 31942
Debugger [baseline] (60.677 ms) : 0, 60677
Debugger [candidate] (60.877 ms) : 0, 60877
Remote Config [baseline] (596.48 µs) : 0, 596
Remote Config [candidate] (601.505 µs) : 0, 602
Telemetry [baseline] (8.179 ms) : 0, 8179
Telemetry [candidate] (8.266 ms) : 0, 8266
Flare Poller [baseline] (4.347 ms) : 0, 4347
Flare Poller [candidate] (4.315 ms) : 0, 4315
section appsec
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (662.202 ms) : 0, 662202
BytebuddyAgent [candidate] (663.208 ms) : 0, 663208
AgentMeter [baseline] (12.217 ms) : 0, 12217
AgentMeter [candidate] (12.225 ms) : 0, 12225
GlobalTracer [baseline] (259.804 ms) : 0, 259804
GlobalTracer [candidate] (260.149 ms) : 0, 260149
AppSec [baseline] (178.503 ms) : 0, 178503
AppSec [candidate] (178.913 ms) : 0, 178913
Debugger [baseline] (66.913 ms) : 0, 66913
Debugger [candidate] (66.725 ms) : 0, 66725
Remote Config [baseline] (642.254 µs) : 0, 642
Remote Config [candidate] (672.33 µs) : 0, 672
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.498 ms) : 0, 8498
Flare Poller [baseline] (3.622 ms) : 0, 3622
Flare Poller [candidate] (3.564 ms) : 0, 3564
IAST [baseline] (24.297 ms) : 0, 24297
IAST [candidate] (24.494 ms) : 0, 24494
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (800.442 ms) : 0, 800442
BytebuddyAgent [candidate] (803.586 ms) : 0, 803586
AgentMeter [baseline] (11.427 ms) : 0, 11427
AgentMeter [candidate] (11.479 ms) : 0, 11479
GlobalTracer [baseline] (249.348 ms) : 0, 249348
GlobalTracer [candidate] (249.682 ms) : 0, 249682
AppSec [baseline] (26.931 ms) : 0, 26931
AppSec [candidate] (26.887 ms) : 0, 26887
Debugger [baseline] (70.789 ms) : 0, 70789
Debugger [candidate] (68.705 ms) : 0, 68705
Remote Config [baseline] (556.746 µs) : 0, 557
Remote Config [candidate] (541.365 µs) : 0, 541
Telemetry [baseline] (9.946 ms) : 0, 9946
Telemetry [candidate] (10.931 ms) : 0, 10931
Flare Poller [baseline] (3.402 ms) : 0, 3402
Flare Poller [candidate] (3.559 ms) : 0, 3559
IAST [baseline] (25.693 ms) : 0, 25693
IAST [candidate] (25.592 ms) : 0, 25592
section profiling
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (690.688 ms) : 0, 690688
BytebuddyAgent [candidate] (692.759 ms) : 0, 692759
AgentMeter [baseline] (9.041 ms) : 0, 9041
AgentMeter [candidate] (9.081 ms) : 0, 9081
GlobalTracer [baseline] (216.838 ms) : 0, 216838
GlobalTracer [candidate] (217.792 ms) : 0, 217792
AppSec [baseline] (32.726 ms) : 0, 32726
AppSec [candidate] (32.982 ms) : 0, 32982
Debugger [baseline] (66.914 ms) : 0, 66914
Debugger [candidate] (66.945 ms) : 0, 66945
Remote Config [baseline] (585.064 µs) : 0, 585
Remote Config [candidate] (595.563 µs) : 0, 596
Telemetry [baseline] (7.908 ms) : 0, 7908
Telemetry [candidate] (7.947 ms) : 0, 7947
Flare Poller [baseline] (3.563 ms) : 0, 3563
Flare Poller [candidate] (3.617 ms) : 0, 3617
ProfilingAgent [baseline] (94.975 ms) : 0, 94975
ProfilingAgent [candidate] (95.081 ms) : 0, 95081
Profiling [baseline] (95.53 ms) : 0, 95530
Profiling [candidate] (95.635 ms) : 0, 95635
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (1.236 ms) : 1225, 1248
. : milestone, 1236,
iast (3.296 ms) : 3252, 3340
. : milestone, 3296,
iast_FULL (6.104 ms) : 6042, 6166
. : milestone, 6104,
iast_GLOBAL (3.759 ms) : 3701, 3818
. : milestone, 3759,
profiling (2.207 ms) : 2186, 2227
. : milestone, 2207,
tracing (1.87 ms) : 1855, 1886
. : milestone, 1870,
section candidate
no_agent (1.23 ms) : 1219, 1242
. : milestone, 1230,
iast (3.292 ms) : 3245, 3340
. : milestone, 3292,
iast_FULL (5.792 ms) : 5734, 5849
. : milestone, 5792,
iast_GLOBAL (3.58 ms) : 3521, 3640
. : milestone, 3580,
profiling (2.259 ms) : 2235, 2282
. : milestone, 2259,
tracing (1.944 ms) : 1926, 1961
. : milestone, 1944,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (17.983 ms) : 17797, 18168
. : milestone, 17983,
appsec (18.883 ms) : 18697, 19070
. : milestone, 18883,
code_origins (18.236 ms) : 18053, 18419
. : milestone, 18236,
iast (17.91 ms) : 17732, 18088
. : milestone, 17910,
profiling (18.769 ms) : 18583, 18955
. : milestone, 18769,
tracing (18.145 ms) : 17967, 18323
. : milestone, 18145,
section candidate
no_agent (18.961 ms) : 18771, 19152
. : milestone, 18961,
appsec (18.56 ms) : 18372, 18749
. : milestone, 18560,
code_origins (18.09 ms) : 17915, 18265
. : milestone, 18090,
iast (18.184 ms) : 18005, 18364
. : milestone, 18184,
profiling (18.917 ms) : 18732, 19103
. : milestone, 18917,
tracing (18.072 ms) : 17893, 18252
. : milestone, 18072,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
appsec (14.673 s) : 14673000, 14673000
. : milestone, 14673000,
iast (18.145 s) : 18145000, 18145000
. : milestone, 18145000,
iast_GLOBAL (17.826 s) : 17826000, 17826000
. : milestone, 17826000,
profiling (15.37 s) : 15370000, 15370000
. : milestone, 15370000,
tracing (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
section candidate
no_agent (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
appsec (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
iast (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
iast_GLOBAL (18.08 s) : 18080000, 18080000
. : milestone, 18080000,
profiling (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
tracing (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~3f82abbf65, baseline=1.61.0-SNAPSHOT~0ee26e896c
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.819 ms) : 3596, 4041
. : milestone, 3819,
iast (2.261 ms) : 2192, 2330
. : milestone, 2261,
iast_GLOBAL (2.302 ms) : 2233, 2372
. : milestone, 2302,
profiling (2.13 ms) : 2073, 2187
. : milestone, 2130,
tracing (2.086 ms) : 2032, 2140
. : milestone, 2086,
section candidate
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (3.835 ms) : 3614, 4056
. : milestone, 3835,
iast (2.259 ms) : 2191, 2328
. : milestone, 2259,
iast_GLOBAL (2.304 ms) : 2235, 2373
. : milestone, 2304,
profiling (2.081 ms) : 2027, 2135
. : milestone, 2081,
tracing (2.074 ms) : 2020, 2128
. : milestone, 2074,
|
# Conflicts: # dd-trace-core/src/main/java/datadog/trace/core/DDSpan.java # dd-trace-core/src/main/java/datadog/trace/core/DDSpanContext.java
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Contributor
|
The following files add Groovy tests to modules that are candidates for migration to Java / JUnit 5:
Consider writing these tests in Java / JUnit 5 instead to help with the ongoing migration effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Java implementation for protocol v1.
Motivation
Additional Notes
DO NOT MERGE, WIP.